Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932139Ab3EBPga (ORCPT ); Thu, 2 May 2013 11:36:30 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:64589 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758743Ab3EBPg3 (ORCPT ); Thu, 2 May 2013 11:36:29 -0400 Date: Thu, 2 May 2013 16:36:24 +0100 From: Lee Jones To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Philippe LANGLAIS , Samuel Ortiz Subject: Re: [PATCH, RFC 10/22] mfd: ab8500: debugfs code depends on gpadc Message-ID: <20130502153624.GN25256@gmail.com> References: <1367507786-505303-1-git-send-email-arnd@arndb.de> <1367507786-505303-11-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1367507786-505303-11-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1715 Lines: 47 On Thu, 02 May 2013, Arnd Bergmann wrote: > The AB8500_DEBUG code specifically requires access to the gpadc code, > not just the common ab8500 driver. > > drivers/built-in.o: In function `ab8500_gpadc_bat_ctrl_print': > mfd/ab8500-debugfs.c:1733: undefined reference to `ab8500_gpadc_get' > mfd/ab8500-debugfs.c:1734: undefined reference to `ab8500_gpadc_read_raw' > mfd/ab8500-debugfs.c:1736: undefined reference to `ab8500_gpadc_ad_to_voltage' > > Cc: Linus Walleij > Cc: Lee Jones > Cc: Philippe LANGLAIS > Cc: Samuel Ortiz > Signed-off-by: Arnd Bergmann > --- > drivers/mfd/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 9b4703e..bf785db 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -580,7 +580,7 @@ config AB8500_CORE > > config AB8500_DEBUG > bool "Enable debug info via debugfs" > - depends on AB8500_CORE && DEBUG_FS > + depends on AB8500_GPADC && DEBUG_FS > default y if DEBUG_FS > help > Select this option if you want debug information using the debug Did you find this with ALLCONFIG out of interest. Applied by the way. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/