Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760509Ab3EBQLu (ORCPT ); Thu, 2 May 2013 12:11:50 -0400 Received: from peace.netnation.com ([204.174.223.2]:48641 "EHLO peace.netnation.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757990Ab3EBQLs (ORCPT ); Thu, 2 May 2013 12:11:48 -0400 Date: Thu, 2 May 2013 09:11:46 -0700 From: Simon Kirby To: Linus Torvalds Cc: Greg Kroah-Hartman , Linux Kernel Mailing List , stable , Jiri Slaby Subject: Re: [ 02/42] TTY: do not update atime/mtime on read/write Message-ID: <20130502161146.GA7454@hostway.ca> References: <20130429184752.435249613@linuxfoundation.org> <20130429184752.700428715@linuxfoundation.org> <20130430001445.GA17260@hostway.ca> <20130430002117.GA4202@kroah.com> <20130430003639.GB17260@hostway.ca> <20130430013724.GA5358@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1989 Lines: 61 On Tue, Apr 30, 2013 at 06:41:44PM -0700, Linus Torvalds wrote: > On Tue, Apr 30, 2013 at 5:57 PM, Linus Torvalds > wrote: > > > > Patch is whitespace-damaged and totally untested! Caveat applicator. > > Ok, so it's still whitespace-damaged, but it seems to work. The > appended has the "8 second rule" too.. > > Comments? Simon? Tested -- both hunks seem to work as intended. Thanks! Simon- Below became b0b885657b6c8ef63a46bc9299b2a7715d19acde > Linus > > --- snip snip --- > drivers/tty/pty.c | 3 +++ > drivers/tty/tty_io.c | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c > index a62798fcc014..59bfaecc4e14 100644 > --- a/drivers/tty/pty.c > +++ b/drivers/tty/pty.c > @@ -681,6 +681,9 @@ static int ptmx_open(struct inode *inode, struct file *filp) > > nonseekable_open(inode, filp); > > + /* We refuse fsnotify events on ptmx, since it's a shared resource */ > + filp->f_mode |= FMODE_NONOTIFY; > + > retval = tty_alloc_file(filp); > if (retval) > return retval; > diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c > index 97ebc8c5864e..6464029e4860 100644 > --- a/drivers/tty/tty_io.c > +++ b/drivers/tty/tty_io.c > @@ -988,10 +988,10 @@ void start_tty(struct tty_struct *tty) > > EXPORT_SYMBOL(start_tty); > > +/* We limit tty time update visibility to every 8 seconds or so. */ > static void tty_update_time(struct timespec *time) > { > - unsigned long sec = get_seconds(); > - sec -= sec % 60; > + unsigned long sec = get_seconds() & ~7; > if ((long)(sec - time->tv_sec) > 0) > time->tv_sec = sec; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/