Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932905Ab3EBTeh (ORCPT ); Thu, 2 May 2013 15:34:37 -0400 Received: from mail-bk0-f43.google.com ([209.85.214.43]:44078 "EHLO mail-bk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932213Ab3EBTef (ORCPT ); Thu, 2 May 2013 15:34:35 -0400 Message-ID: <5182BFC6.3070709@gmail.com> Date: Thu, 02 May 2013 21:34:30 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Arnd Bergmann CC: Jason Gunthorpe , Andrew Lunn , Russell King , Jason Cooper , Jean-Francois Moine , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Grant Likely , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip: add support for Marvell Orion SoCs References: <1367519104-19677-1-git-send-email-sebastian.hesselbarth@gmail.com> <20130502185322.GA29333@obsidianresearch.com> <201305022111.41043.arnd@arndb.de> In-Reply-To: <201305022111.41043.arnd@arndb.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 31 On 05/02/2013 09:11 PM, Arnd Bergmann wrote: > On Thursday 02 May 2013, Jason Gunthorpe wrote: >>> +static struct of_device_id orion_irq_dt_ids[] __initconst = { >>> + { .compatible = "marvell,orion-mpic", .data = orion_of_init }, >>> + { } >> >> Is there a strong reason to change the compatible string? Looks to me >> like either the new driver or the old driver will bind depending on >> what is in the machine description. No need for a new string? >> > > The compatible string should change if the binding changes in an > incomptible way, and we should try not to change it unless it's > fundamentally flawed. Well, there is no _fundamental_ change in the binding syntax as it is only reg, interrupts, and clocks. But there is a semantic change in reg properties, as current orion irq controller wants the mask registers (0x04,0x08) only while this also needs cause register (0x00). Nothing that couldn't be handled while moving Orion arch to irqchip but if there are no further objections, I'd like to stick with the new compatible string - also having orion-spic in mind. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/