Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932981Ab3EBThe (ORCPT ); Thu, 2 May 2013 15:37:34 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:57781 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932507Ab3EBThd (ORCPT ); Thu, 2 May 2013 15:37:33 -0400 Date: Thu, 2 May 2013 13:37:26 -0600 From: Jason Gunthorpe To: Sebastian Hesselbarth Cc: Arnd Bergmann , Andrew Lunn , Russell King , Jason Cooper , Jean-Francois Moine , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Grant Likely , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip: add support for Marvell Orion SoCs Message-ID: <20130502193726.GA29622@obsidianresearch.com> References: <1367519104-19677-1-git-send-email-sebastian.hesselbarth@gmail.com> <20130502185322.GA29333@obsidianresearch.com> <201305022111.41043.arnd@arndb.de> <5182BFC6.3070709@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5182BFC6.3070709@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.162 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 21 On Thu, May 02, 2013 at 09:34:30PM +0200, Sebastian Hesselbarth wrote: > >The compatible string should change if the binding changes in an > >incomptible way, and we should try not to change it unless it's > >fundamentally flawed. > > Well, there is no _fundamental_ change in the binding syntax as it > is only reg, interrupts, and clocks. But there is a semantic change > in reg properties, as current orion irq controller wants the mask > registers (0x04,0x08) only while this also needs cause register > (0x00). Oh, I didn't notice that, good point - the original binding was flawed in that regard :| Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/