Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762372Ab3ECAKd (ORCPT ); Thu, 2 May 2013 20:10:33 -0400 Received: from mail-qc0-f175.google.com ([209.85.216.175]:56110 "EHLO mail-qc0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758404Ab3ECAKb (ORCPT ); Thu, 2 May 2013 20:10:31 -0400 Date: Thu, 2 May 2013 17:10:26 -0700 From: Tejun Heo To: "Rafael J. Wysocki" Cc: Colin Cross , Oleg Nesterov , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, arve@android.com Subject: Re: [PATCH v2 00/10] optimize freezing tasks by reducing task wakeups Message-ID: <20130503001026.GZ19814@mtj.dyndns.org> References: <1367458508-9133-1-git-send-email-ccross@android.com> <1678114.cijx7evM08@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1678114.cijx7evM08@vostro.rjw.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 856 Lines: 26 Hey, Rafael. On Thu, May 02, 2013 at 11:06:35PM +0200, Rafael J. Wysocki wrote: > > v2 moves the skip check to freeze_task(), and expands the commit > > messages. > > The entire series makes sense to me, so are there any objections? > > Tejun, Oleg?? Generally looks good to me. I'm a bit uncomfortable with the generic-looking expansion of the freezable API as it can't be something which can be used in any generic manner. It'd be great if we just add only the used ones (do we already?) and add some sort of lockdep annotation so that people don't use them while holding any locks. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/