Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762377Ab3ECHIP (ORCPT ); Fri, 3 May 2013 03:08:15 -0400 Received: from eu1sys200aog115.obsmtp.com ([207.126.144.139]:38116 "EHLO eu1sys200aog115.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752404Ab3ECHIN (ORCPT ); Fri, 3 May 2013 03:08:13 -0400 Date: Fri, 3 May 2013 12:37:14 +0530 From: Srinidhi Kasagar To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , Linus WALLEIJ , Greg Kroah-Hartman , "devel@driverdev.osuosl.org" Subject: Re: [PATCH 4/4] staging: =?utf-8?Q?ste=5Fr?= =?utf-8?Q?mi4=3A_Suppress_'ignoring_return_value_of_=E2=80=98regulator=5F?= =?utf-8?B?ZW5hYmxlKCkn?= warning Message-ID: <20130503070713.GA27956@bnru09> References: <1367509690-24022-1-git-send-email-lee.jones@linaro.org> <1367509690-24022-5-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1367509690-24022-5-git-send-email-lee.jones@linaro.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1670 Lines: 43 On Thu, May 02, 2013 at 17:48:10 +0200, Lee Jones wrote: > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c: > In function ‘synaptics_rmi4_resume’: > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c:1090:18: > warning: ignoring return value of ‘regulator_enable’, declared > with attribute warn_unused_result [-Wunused-result > > Cc: Greg Kroah-Hartman > Cc: devel@driverdev.osuosl.org > Signed-off-by: Lee Jones > --- > drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c > index fe667dd..c4d013d 100644 > --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c > +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c > @@ -1087,7 +1087,9 @@ static int synaptics_rmi4_resume(struct device *dev) > unsigned char intr_status; > struct synaptics_rmi4_data *rmi4_data = dev_get_drvdata(dev); > > - regulator_enable(rmi4_data->regulator); > + retval = regulator_enable(rmi4_data->regulator); > + if (retval < 0) > + return retval; Does it make sense to add a dev_err? Otherwise, you can add my Acked-by:srinidhi kasagar for this series. > > enable_irq(rmi4_data->i2c_client->irq); > rmi4_data->touch_stopped = false; > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/