Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762597Ab3ECI2b (ORCPT ); Fri, 3 May 2013 04:28:31 -0400 Received: from mail-ia0-f182.google.com ([209.85.210.182]:49620 "EHLO mail-ia0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750832Ab3ECI23 convert rfc822-to-8bit (ORCPT ); Fri, 3 May 2013 04:28:29 -0400 MIME-Version: 1.0 In-Reply-To: <1367509690-24022-3-git-send-email-lee.jones@linaro.org> References: <1367509690-24022-1-git-send-email-lee.jones@linaro.org> <1367509690-24022-3-git-send-email-lee.jones@linaro.org> Date: Fri, 3 May 2013 10:28:28 +0200 Message-ID: Subject: Re: [PATCH 2/4] mfd: ab8500-gpadc: Suppress 'ignoring regulator_enable() return value' warning From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR , Samuel Ortiz , =?ISO-8859-1?Q?Bengt_J=F6nsson?= Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 41 On Thu, May 2, 2013 at 5:48 PM, Lee Jones wrote: > drivers/mfd/ab8500-gpadc.c: In function ?ab8500_gpadc_resume?: > drivers/mfd/ab8500-gpadc.c:911:18: warning: ignoring return value of > ?regulator_enable?, declared with attribute warn_unused_result > [-Wunused-result] > > Cc: Samuel Ortiz > Signed-off-by: Lee Jones > --- > drivers/mfd/ab8500-gpadc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c > index 5e65b28..7278e53 100644 > --- a/drivers/mfd/ab8500-gpadc.c > +++ b/drivers/mfd/ab8500-gpadc.c > @@ -907,8 +907,11 @@ static int ab8500_gpadc_suspend(struct device *dev) > static int ab8500_gpadc_resume(struct device *dev) > { > struct ab8500_gpadc *gpadc = dev_get_drvdata(dev); > + int ret; > > - regulator_enable(gpadc->regu); > + ret = regulator_enable(gpadc->regu); > + if (ret < 0) > + return ret; > > pm_runtime_mark_last_busy(gpadc->dev); > pm_runtime_put_autosuspend(gpadc->dev); > -- > 1.7.10.4 Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/