Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762810Ab3ECIvx (ORCPT ); Fri, 3 May 2013 04:51:53 -0400 Received: from mail-vc0-f173.google.com ([209.85.220.173]:49087 "EHLO mail-vc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750843Ab3ECIvv (ORCPT ); Fri, 3 May 2013 04:51:51 -0400 MIME-Version: 1.0 In-Reply-To: <1367325906-23045-1-git-send-email-fabio.baltieri@linaro.org> References: <1367325906-23045-1-git-send-email-fabio.baltieri@linaro.org> Date: Fri, 3 May 2013 10:51:50 +0200 Message-ID: Subject: Re: [PATCH] clk: ux500: clk-sysctrl: handle clocks with no parents From: Ulf Hansson To: Fabio Baltieri Cc: Mike Turquette , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linus Walleij , Lee Jones Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1724 Lines: 47 On 30 April 2013 14:45, Fabio Baltieri wrote: > Fix clk_reg_sysctrl() to set main clock registers of new struct > clk_sysctrl even if the registered clock has no parents. > > This fixes an issue where "ulpclk" was registered with all clk->reg_* > fields uninitialized, causing a -EINVAL error from clk_prepare(). > > Cc: Ulf Hansson > Signed-off-by: Fabio Baltieri > --- > drivers/clk/ux500/clk-sysctrl.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c > index bc7e9bd..e364c9d 100644 > --- a/drivers/clk/ux500/clk-sysctrl.c > +++ b/drivers/clk/ux500/clk-sysctrl.c > @@ -145,7 +145,13 @@ static struct clk *clk_reg_sysctrl(struct device *dev, > return ERR_PTR(-ENOMEM); > } > > - for (i = 0; i < num_parents; i++) { > + /* set main clock registers */ > + clk->reg_sel[0] = reg_sel[0]; > + clk->reg_bits[0] = reg_bits[0]; > + clk->reg_mask[0] = reg_mask[0]; > + > + /* handle clocks with more than one parent */ > + for (i = 1; i < num_parents; i++) { > clk->reg_sel[i] = reg_sel[i]; > clk->reg_bits[i] = reg_bits[i]; > clk->reg_mask[i] = reg_mask[i]; > -- > 1.8.2 > Acked-by: Ulf Hansson This is bugfix, should go "stable" as well? Kind regards Ulf Hansson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/