Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933061Ab3ECJzU (ORCPT ); Fri, 3 May 2013 05:55:20 -0400 Received: from mail.nanl.de ([217.115.11.12]:40146 "EHLO mail.nanl.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762976Ab3ECJzR (ORCPT ); Fri, 3 May 2013 05:55:17 -0400 MIME-Version: 1.0 In-Reply-To: References: <1367527692-25809-1-git-send-email-ddaney.cavm@gmail.com> From: Jonas Gorski Date: Fri, 3 May 2013 11:54:43 +0200 Message-ID: Subject: Re: [PATCH] MIPS: Enable interrupts before WAIT instruction. To: Thomas Gleixner Cc: David Daney , linux-mips@linux-mips.org, ralf@linux-mips.org, Linus Torvalds , linux-kernel@vger.kernel.org, David Daney Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 29 On Thu, May 2, 2013 at 11:04 PM, Thomas Gleixner wrote: > > > On Thu, 2 May 2013, David Daney wrote: > >> From: David Daney >> >> As noted by Thomas Gleixner: >> >> commit cdbedc61c8 (mips: Use generic idle loop) broke MIPS as I did >> not realize that MIPS wants to invoke the wait instructions with >> interrupts enabled. >> >> Instead of enabling interrupts in arch_cpu_idle() as Thomas' initial >> patch does, we follow Linus' suggestion of doing it in the assembly >> code to prevent the compiler from rearranging things. > > Yeah, that looks way more sane. In a first quick test I can also confirm that it seems to work (as an alternative to the other fix). Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/