Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762742Ab3ECNw2 (ORCPT ); Fri, 3 May 2013 09:52:28 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:52262 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762496Ab3ECNw0 (ORCPT ); Fri, 3 May 2013 09:52:26 -0400 X-Auth-Info: XFGYXa0I/aVJwmReZcxGpgZ67B6q62iuD9+e7AM3uEw= Date: Fri, 3 May 2013 15:52:23 +0200 From: Anatolij Gustschin To: Alexander Popov Cc: Vinod Koul , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Dan Williams Subject: Re: [PATCH 1/1] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory Message-ID: <20130503155223.1eff1d9f@crub> In-Reply-To: References: <1367407689-16252-1-git-send-email-a13xp0p0v88@gmail.com> <20130502171452.GP1960@intel.com> <20130503085944.69ef751e@crub> X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1322 Lines: 41 Hello Alexander, On Fri, 3 May 2013 14:43:23 +0400 Alexander Popov wrote: > Hello Anatolij, > > > Note that there is a patch for .device_prep_slave_sg() operation > > for this driver as part of this series: > > https://patchwork.kernel.org/patch/2368581/ > > https://patchwork.kernel.org/patch/2368591/ > Thanks, I haven't seen that patch. > It's certainly what my SCLPC device driver needs > (http://patchwork.ozlabs.org/patch/241010/). > I will send the second version of it which uses .device_prep_slave_sg(). > > > maybe you can reuse and improve it. > > Anatolij > Should I propose my additions at https://patchwork.kernel.org/patch/2368591/ ? Yes, I think so. I only used drivers new .device_prep_slave_sg() for SDHC DMA channel transfers up to now. Adding support for other peripherals would be good. With generic DMA DT bindings patch for this driver you can use dmas = <&dma0 26>; dma-names = "rx-tx"; in your sclpc@10100 DT node and then dma_request_slave_channel(&pdev->dev, "rx-tx") in the lpbfifo driver. Thanks, Anatolij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/