Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763623Ab3ECUsV (ORCPT ); Fri, 3 May 2013 16:48:21 -0400 Received: from mail-ia0-f169.google.com ([209.85.210.169]:36135 "EHLO mail-ia0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763577Ab3ECUsU (ORCPT ); Fri, 3 May 2013 16:48:20 -0400 MIME-Version: 1.0 In-Reply-To: <1367591569-32197-23-git-send-email-lee.jones@linaro.org> References: <1367591569-32197-1-git-send-email-lee.jones@linaro.org> <1367591569-32197-23-git-send-email-lee.jones@linaro.org> Date: Fri, 3 May 2013 22:48:20 +0200 Message-ID: Subject: Re: [PATCH 22/63] dmaengine: ste_dma40: Move rev error-check up to revision acquisition From: Linus Walleij To: Lee Jones Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann , Linus WALLEIJ , Srinidhi KASAGAR Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 875 Lines: 22 On Fri, May 3, 2013 at 4:32 PM, Lee Jones wrote: > At the moment we fetch the hardware revision, then do some stuff, then > check whether the revision is correct and return in error if it's not. > Well we may as well check it as soon as we know what it is, so let's > move the check right up underneath where we acquire the version. > > Acked-by: Vinod Koul > Reviewed-by: Linus Walleij > Signed-off-by: Lee Jones Applied to my ux500-dm40 branch. (Notice I didn't apply 20 and 21 so now I'm screwing around.) Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/