Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752339Ab3EDFDN (ORCPT ); Sat, 4 May 2013 01:03:13 -0400 Received: from mail-ia0-f181.google.com ([209.85.210.181]:47961 "EHLO mail-ia0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214Ab3EDFDM (ORCPT ); Sat, 4 May 2013 01:03:12 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130430212007.GB18598@redhat.com> <20130430213719.GA14988@redhat.com> <20130502154621.GA23990@redhat.com> <20130503144912.GB1283@redhat.com> Date: Fri, 3 May 2013 22:03:11 -0700 X-Google-Sender-Auth: FcX5Numq991sQUyLJP2FK_EhFSs Message-ID: Subject: Re: clockevents_program_event WARN_ON preventing boot. From: Yinghai Lu To: Thomas Gleixner Cc: Dave Jones , Linux Kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2189 Lines: 49 On Fri, May 3, 2013 at 11:32 AM, Thomas Gleixner wrote: > Subject: tick: Use zalloc_cpumask_var for allocating offstack cpumasks > From: Thomas Gleixner > Date: Fri, 03 May 2013 20:22:36 +0200 > > commit b352bc1cbc (tick: Convert broadcast cpu bitmaps to > cpumask_var_t) broke CONFIG_CPUMASK_OFFSTACK in a very subtle way. > > Instead of allocating the cpumasks with zalloc_cpumask_var it uses > alloc_cpumask_var, so we can get random data there, which of course > confuses the logic completely and causes random failures. > > Reported-by: Dave Jones > Reported-by: Yinghai Lu > Signed-off-by: Thomas Gleixner > --- > kernel/time/tick-broadcast.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > Index: linux-2.6/kernel/time/tick-broadcast.c > =================================================================== > --- linux-2.6.orig/kernel/time/tick-broadcast.c > +++ linux-2.6/kernel/time/tick-broadcast.c > @@ -785,11 +785,11 @@ bool tick_broadcast_oneshot_available(vo > > void __init tick_broadcast_init(void) > { > - alloc_cpumask_var(&tick_broadcast_mask, GFP_NOWAIT); > - alloc_cpumask_var(&tmpmask, GFP_NOWAIT); > + zalloc_cpumask_var(&tick_broadcast_mask, GFP_NOWAIT); > + zalloc_cpumask_var(&tmpmask, GFP_NOWAIT); > #ifdef CONFIG_TICK_ONESHOT > - alloc_cpumask_var(&tick_broadcast_oneshot_mask, GFP_NOWAIT); > - alloc_cpumask_var(&tick_broadcast_pending_mask, GFP_NOWAIT); > - alloc_cpumask_var(&tick_broadcast_force_mask, GFP_NOWAIT); > + zalloc_cpumask_var(&tick_broadcast_oneshot_mask, GFP_NOWAIT); > + zalloc_cpumask_var(&tick_broadcast_pending_mask, GFP_NOWAIT); > + zalloc_cpumask_var(&tick_broadcast_force_mask, GFP_NOWAIT); > #endif > } Yes, it works on Nehalem-EX 8 socket system now. Tested-by: Yinghai Lu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/