Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756147Ab3EDKLy (ORCPT ); Sat, 4 May 2013 06:11:54 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:65366 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752730Ab3EDKLx (ORCPT ); Sat, 4 May 2013 06:11:53 -0400 MIME-Version: 1.0 In-Reply-To: <51838C3E.5090303@metafoo.de> References: <51838C3E.5090303@metafoo.de> Date: Sat, 4 May 2013 18:11:51 +0800 Message-ID: Subject: Re: [PATCH -next] power: fix bq27x00_battery kconfig From: zhou jencce To: Lars-Peter Clausen Cc: anton@enomsg.org, dwmw2@infradead.org, linux-next@vger.kernel.org, Stephen Rothwell , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2438 Lines: 71 2013/5/3 Lars-Peter Clausen : > On 05/03/2013 11:56 AM, Xiong Zhou wrote: >> From: Xiong Zhou >> >> This patch fixes build failure(randconfig) of next-20130501. >> When config I2C as m, BATTERY_BQ27x00 as y, here comes the failure. >> BATTERY_BQ27x00 depends on I2C according to the code. >> > >> Failure message: >> drivers/built-in.o: In function `bq27x00_read_i2c': >> bq27x00_battery.c:(.text+0x1082a7): undefined reference to `i2c_transfer' >> drivers/built-in.o: In function `bq27x00_battery_init': >> bq27x00_battery.c:(.init.text+0x6085): undefined reference to `i2c_register_driver' >> bq27x00_battery.c:(.init.text+0x60c7): undefined reference to `i2c_del_driver' >> drivers/built-in.o: In function `bq27x00_battery_exit': >> bq27x00_battery.c:(.exit.text+0xbf0): undefined reference to `i2c_del_driver' >> make: *** [vmlinux] Error 1 >> >> Signed-off-by: Xiong Zhou > > It's actually a bit more tricky. The driver can be built without I2C What about the build error ? > support, so it does not depend on I2C, but if I2C is built as a module the > driver should also only be built as a module. And this is what this patch trying to do. > > I think the best solution is to put the platform code and the i2c code of > the bq27x00 driver each in their on module, but if you want a quick solution Yes, more clear. > > depends on I2C || I2C=n > > should work. > Thanks. :) >> --- >> drivers/power/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig >> index 0d0b5d7..89e5ebd 100644 >> --- a/drivers/power/Kconfig >> +++ b/drivers/power/Kconfig >> @@ -152,6 +152,7 @@ config BATTERY_SBS >> >> config BATTERY_BQ27x00 >> tristate "BQ27x00 battery driver" >> + depends on I2C >> help >> Say Y here to enable support for batteries with BQ27x00 (I2C/HDQ) chips. >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/