Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759204Ab3EDTLc (ORCPT ); Sat, 4 May 2013 15:11:32 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:58742 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938Ab3EDTL3 (ORCPT ); Sat, 4 May 2013 15:11:29 -0400 From: "Rafael J. Wysocki" To: Tejun Heo Cc: Colin Cross , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, arve@android.com, Oleg Nesterov , "David S. Miller" , Eric Dumazet , Al Viro , "Eric W. Biederman" , Gao feng , netdev@vger.kernel.org Subject: Re: [PATCH v2 10/10] af_unix: use freezable blocking calls in read Date: Sat, 04 May 2013 21:19:49 +0200 Message-ID: <85487641.pdFCOjE3G7@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.9.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <20130503000812.GY19814@mtj.dyndns.org> References: <1367458508-9133-1-git-send-email-ccross@android.com> <1367458508-9133-11-git-send-email-ccross@android.com> <20130503000812.GY19814@mtj.dyndns.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1263 Lines: 31 On Thursday, May 02, 2013 05:08:12 PM Tejun Heo wrote: > On Wed, May 01, 2013 at 06:35:08PM -0700, Colin Cross wrote: > > Avoid waking up every thread sleeping in read call on an AF_UNIX > > socket during suspend and resume by calling a freezable blocking > > call. Previous patches modified the freezer to avoid sending > > wakeups to threads that are blocked in freezable blocking calls. > > > > This call was selected to be converted to a freezable call because > > it doesn't hold any locks or release any resources when interrupted > > that might be needed by another freezing task or a kernel driver > > during suspend, and is a common site where idle userspace tasks are > > blocked. > > Heh, so you are aware of the deadlock possibilities. Good selection > of spots. For all the conversion patches. > > Acked-by: Tejun Heo I wonder if that includes [3/10] (just to get the record straight)? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/