Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753723Ab3EFHuE (ORCPT ); Mon, 6 May 2013 03:50:04 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:60286 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753304Ab3EFHuB (ORCPT ); Mon, 6 May 2013 03:50:01 -0400 Message-ID: <5187609C.5050209@linux.vnet.ibm.com> Date: Mon, 06 May 2013 15:49:48 +0800 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Alex Shi CC: mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, akpm@linux-foundation.org, bp@alien8.de, pjt@google.com, namhyung@kernel.org, efault@gmx.de, morten.rasmussen@arm.com, vincent.guittot@linaro.org, preeti@linux.vnet.ibm.com, viresh.kumar@linaro.org, linux-kernel@vger.kernel.org, mgorman@suse.de, riel@redhat.com Subject: Re: [PATCH v5 7/7] sched: consider runnable load average in effective_load References: <1367804711-30308-1-git-send-email-alex.shi@intel.com> <1367804711-30308-8-git-send-email-alex.shi@intel.com> <518724D1.9040006@linux.vnet.ibm.com> <51874229.8050202@intel.com> In-Reply-To: <51874229.8050202@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13050607-4790-0000-0000-0000082CB83F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 55 On 05/06/2013 01:39 PM, Alex Shi wrote: [snip] Rough test done: > > 1, change back the tg_weight in calc_tg_weight() to use tg_load_contrib not direct load. This way stop the regression of patch 7. > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 6f4f14b..c770f8d 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1037,8 +1037,8 @@ static inline long calc_tg_weight(struct task_group *tg, struct cfs_rq *cfs_rq) > * update_cfs_rq_load_contribution(). > */ > tg_weight = atomic64_read(&tg->load_avg); > - tg_weight -= cfs_rq->tg_load_contrib; > - tg_weight += cfs_rq->load.weight; > + //tg_weight -= cfs_rq->tg_load_contrib; > + //tg_weight += cfs_rq->load.weight; > > return tg_weight; > } > > 2, another try is follow the current calc_tg_weight, so remove the follow change. This way show even better results than only patch 1~6. But the way Preeti suggested doesn't works... May be we should record some explanation about this change here, do we? Regards, Michael Wang > >>>> @@ -3045,7 +3045,7 @@ static long effective_load(struct task_group *tg, int cpu, long wl, long wg) >>>> /* >>>> * w = rw_i + @wl >>>> */ >>>> - w = se->my_q->load.weight + wl; >>>> + w = se->my_q->tg_load_contrib + wl; > > Would you like to try them? > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/