Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754070Ab3EFNLe (ORCPT ); Mon, 6 May 2013 09:11:34 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:17595 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753174Ab3EFNLc (ORCPT ); Mon, 6 May 2013 09:11:32 -0400 Message-ID: <5187ABF9.4000903@huawei.com> Date: Mon, 6 May 2013 21:11:21 +0800 From: Libo Chen User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: CC: , , , Li Zefan Subject: [PATCH 2/2] i2c: pxa: no need release_mem_region before request_mem_region successful Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.72.158] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 42 move release_mem_region above kfree(i2c) && below clk_put(i2c->clk) Signed-off-by: Libo Chen --- drivers/i2c/busses/i2c-pxa.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index ea6d45d..3188cd0 100644 --- a/drivers/i2c/busses/i2c-pxa.c +++ b/drivers/i2c/busses/i2c-pxa.c @@ -1129,7 +1129,7 @@ static int i2c_pxa_probe(struct platform_device *dev) i2c->clk = clk_get(&dev->dev, NULL); if (IS_ERR(i2c->clk)) { ret = PTR_ERR(i2c->clk); - goto eclk; + goto emm; } i2c->reg_base = ioremap(res->start, resource_size(res)); @@ -1206,10 +1206,11 @@ ereqirq: iounmap(i2c->reg_base); eremap: clk_put(i2c->clk); +emm: + release_mem_region(res->start, resource_size(res)); eclk: kfree(i2c); emalloc: - release_mem_region(res->start, resource_size(res)); return ret; } -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/