Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754121Ab3EFOpB (ORCPT ); Mon, 6 May 2013 10:45:01 -0400 Received: from mail-we0-f181.google.com ([74.125.82.181]:64720 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120Ab3EFOo7 (ORCPT ); Mon, 6 May 2013 10:44:59 -0400 MIME-Version: 1.0 In-Reply-To: <20130430023146.8F351660923@gitolite.kernel.org> References: <20130430023146.8F351660923@gitolite.kernel.org> Date: Mon, 6 May 2013 10:44:58 -0400 Message-ID: Subject: Re: workqueue: inline trivial wrappers From: Marc Dionne To: Tejun Heo , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1718 Lines: 45 On Mon, Apr 29, 2013 at 10:31 PM, Linux Kernel Mailing List wrote: > Gitweb: http://git.kernel.org/linus/;a=commit;h=8425e3d5bdbe8e741d2c73cf3189ed59b4038b84 > Commit: 8425e3d5bdbe8e741d2c73cf3189ed59b4038b84 > Parent: 611c92a0203091bb022edec7e2d8b765fe148622 > Author: Tejun Heo > AuthorDate: Wed Mar 13 16:51:36 2013 -0700 > Committer: Tejun Heo > CommitDate: Wed Mar 13 16:51:36 2013 -0700 > > workqueue: inline trivial wrappers > > There's no reason to make these trivial wrappers full (exported) > functions. Inline the followings. > > queue_work() > queue_delayed_work() > mod_delayed_work() > schedule_work_on() > schedule_work() > schedule_delayed_work_on() > schedule_delayed_work() > keventd_up() > > Signed-off-by: Tejun Heo Hi Tejun, This commit has the side effect of making some functions EXPORT_SYMBOL_GPL that had been previously exported with EXPORT_SYMBOL for a long time, such as schedule_work(). This is used by OpenAFS and probably other out of tree modules. Past exchanges on this list (ex: http://marc.info/?l=linux-fsdevel&m=123550631318910) suggest the license requirements for existing interfaces shouldn't change, at least without providing an alternate means of getting the same functionality. Any thoughts on whether this can be adjusted within the current release cycle? Thanks, Marc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/