Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760322Ab3EGC6D (ORCPT ); Mon, 6 May 2013 22:58:03 -0400 Received: from mail-oa0-f41.google.com ([209.85.219.41]:44225 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757213Ab3EGC6A (ORCPT ); Mon, 6 May 2013 22:58:00 -0400 MIME-Version: 1.0 In-Reply-To: <20130506234717.GA1703@somewhere> References: <1367556468-4021-1-git-send-email-kosaki.motohiro@gmail.com> <1367556468-4021-3-git-send-email-kosaki.motohiro@gmail.com> <20130506234717.GA1703@somewhere> From: KOSAKI Motohiro Date: Mon, 6 May 2013 22:57:38 -0400 Message-ID: Subject: Re: [PATCH 1/7] posix-cpu-timers: don't account cpu timer after stopped thread runtime accounting To: Frederic Weisbecker Cc: LKML , Olivier Langlois , Thomas Gleixner , Ingo Molnar , Peter Zijlstra Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 25 >> + /* >> + * After turning over se.sum_exec_runtime to sig->sum_sched_runtime >> + * in __exit_signal(), we must not account exec_runtime for consistency. >> + */ >> + if (unlikely(!tsk->sighand)) >> + return; > > Ok, if we want the clock and timer to be consistent, do we also want the same check in > account_group_user_time() and account_group_system_time()? The task can still account > a tick after autoreaping itself between release_task() and the final schedule(). You are right. That said, current the man pages don't describe this linux specific extensions. So, nobody (glibc, ltp, and me) tested them. Please give me a couple of days. I'll test and fix this features too. timer_create(2): http://man7.org/linux/man-pages/man2/timer_create.2.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/