Message-id: <1367922839.16581.42.camel@kjgkr>
Subject: Re: [PATCH 4/4] f2fs: optimize build_free_nids()
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Reply-to: jaegeuk.kim@samsung.com
To: Haicheng Li <haicheng.li@linux.intel.com>
Cc: linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Haicheng Li <haicheng.lee@gmail.com>
Date: Tue, 07 May 2013 19:33:59 +0900
In-reply-to: <1367853344-28938-5-git-send-email-haicheng.li@linux.intel.com>
References: <1367853344-28938-1-git-send-email-haicheng.li@linux.intel.com>
 <1367853344-28938-5-git-send-email-haicheng.li@linux.intel.com>
Organization: samsung
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-ujGAJO0sZkMGphlpYptQ"
MIME-version: 1.0
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2256
Lines: 71


--=-ujGAJO0sZkMGphlpYptQ
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

2013-05-06 (=EC=9B=94), 23:15 +0800, Haicheng Li:
> When nm_i->fcnt > 2 * MAX_FREE_NIDS, stop scanning other NAT pages.
>=20
> Signed-off-by: Haicheng Li <haicheng.li@linux.intel.com>
> ---
>  fs/f2fs/node.c |    2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 1fe3fe2..3136224 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -1342,6 +1342,8 @@ static void build_free_nids(struct f2fs_sb_info *sb=
i)
>  		if (nid >=3D nm_i->max_nid)
>  			nid =3D 0;
> =20
> +		if (nm_i->fcnt > 2 * MAX_FREE_NIDS)
> +			break;

Could you explain when this can happen?

IMO, this is an unnecessary condition check, since the below condition
that includes FREE_NID_PAGES already limits the number of free nids.
Thanks,

>  		if (i++ =3D=3D FREE_NID_PAGES)
>  			break;
>  	}

--=20
Jaegeuk Kim
Samsung

--=-ujGAJO0sZkMGphlpYptQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAABAgAGBQJRiNiXAAoJEEAUqH6CSFDSogkP/1/YJNe2b2Tdt2EuMX53sO/7
9Goy4BrZkJV1+w15Dj/tP3TDg+kRKot58PWqUblARww3R9YF+aPl4pr401vjtAeh
JQh9iEgwfutbrlbZTRG1SapWNMYD5wQAcWUN5rfdDRRQeCu5CUdFs+VzdHoPIj0k
CPz8fpsSwthJW03Apt5pRJIntfUfRCg3GYOLjYTS809Hdhrhv2PnVx3EXRax/daU
lIqcNg9vj4JZflDlMPZf6tumTbWZCsoCKaArHfnxlJl1YlNckjZZbITdzcPhh3wk
B6aOJep5utRWVbfQ9UFPy7GfJ18VrGutt8U4JImvBgkBEdDjBs/5geqb85qTOufL
QMmULibfR3t5dEh7lJ+ePort8Pzv/Dlx6xwamaI4xIK4PMwxGLsMbOJsr1+Nka2B
d7dazH60zPBDasBr46cVEVlUyGac8EdpsENlJl5p7en4IgebmTn1TJIra5O0T9WU
/aH+j0gLkX8F8RVDWQG9EqaCymM8qGeDU5OQFxieJTSqJ++M02/RxAWwFQxT6Kem
wDU7gBaieqpl0ZNfDlGquclfCEPvrNm1DuK/8lEedS3Utr1KRKtSHEDfR+VAKzTP
UJIBmSBWUkG3ZFuqI4VSwAmHIYASgsW3Oy1CUUl9DtjMqw/D4Jw449waMAe5CW0w
iT6R9hYSv4kg/1un/dBc
=C7dS
-----END PGP SIGNATURE-----

--=-ujGAJO0sZkMGphlpYptQ--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/