Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933663Ab3EGNrZ (ORCPT ); Tue, 7 May 2013 09:47:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40533 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933381Ab3EGNrV (ORCPT ); Tue, 7 May 2013 09:47:21 -0400 Message-ID: <518905E6.5050502@suse.cz> Date: Tue, 07 May 2013 15:47:18 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: "Yann E. MORIN" Cc: Li Zefan , Andrew Morton , Weng Meiling , Libo Chen , LKML , linux-kbuild@vger.kernel.org, Borislav Petkov Subject: Re: [PATCH] menuconfig: fix NULL pointer dereference when searching a symbol References: <518869BB.2020808@huawei.com> <20130507132159.GA15137@free.fr> In-Reply-To: <20130507132159.GA15137@free.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 35 On 7.5.2013 15:21, Yann E. MORIN wrote: > Li, All, > > On Tue, May 07, 2013 at 10:40:59AM +0800, Li Zefan wrote: >> Searching PPC_EFIKA results segmentation fault, and it's because >> get_symbol_prop() returns NULL. >> >> In this case CONFIG_PPC_EFIKA is defined in arch/powerpc/platforms/ >> 52xx/Kconfig, so it won't be parsed if ARCH!=PPC, but menuconfig >> knows this symbol when it parses sound/soc/fsl/Kconfig: >> >> config SND_MPC52xx_SOC_EFIKA >> tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" >> depends on PPC_EFIKA >> >> This bug was introduced by commit bcdedcc1afd6 ("menuconfig: print more >> info for symbol without prompts"). >> >> Reported-by: Borislav Petkov >> Signed-off-by: Li Zefan > > Reviewed-by: "Yann E. MORIN" > > Michal, I'll get this in my tree, and will send a pull-request to you > later (I may have a few other smallish fixes shortly). It's difficult to apply this to kbuild.git#kconfig, because the bug that it is fixing is not there. I will send it to Linus by mail. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/