MIME-Version: 1.0
In-Reply-To: <CAHGf_=rvYP8jFYHULbJJo4by7eqsPKE_qR+6xcBebLNsMn1=mw@mail.gmail.com>
References: <1367556468-4021-1-git-send-email-kosaki.motohiro@gmail.com>
	<1367556468-4021-3-git-send-email-kosaki.motohiro@gmail.com>
	<20130506234717.GA1703@somewhere>
	<CAHGf_=rvYP8jFYHULbJJo4by7eqsPKE_qR+6xcBebLNsMn1=mw@mail.gmail.com>
Date: Tue, 7 May 2013 17:24:44 +0200
Message-ID: <CAFTL4hxL+Y9GrEd3_EqvUL6P0qDUhCNrDdNQc0ODj8y4aYztxw@mail.gmail.com>
Subject: Re: [PATCH 1/7] posix-cpu-timers: don't account cpu timer after
 stopped thread runtime accounting
From: Frederic Weisbecker <fweisbec@gmail.com>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Olivier Langlois <olivier@trillion01.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1459
Lines: 36

2013/5/7 KOSAKI Motohiro <kosaki.motohiro@gmail.com>:
>>> +     /*
>>> +      * After turning over se.sum_exec_runtime to sig->sum_sched_runtime
>>> +      * in __exit_signal(), we must not account exec_runtime for consistency.
>>> +      */
>>> +     if (unlikely(!tsk->sighand))
>>> +             return;
>>
>> Ok, if we want the clock and timer to be consistent, do we also want the same check in
>> account_group_user_time() and account_group_system_time()? The task can still account
>> a tick after autoreaping itself between release_task() and the final schedule().
>
> You are right.
>
> That said, current the man pages don't describe this linux specific
> extensions. So, nobody
> (glibc, ltp, and me) tested them. Please give me a couple of days.
> I'll test and fix this features
> too.
>
> timer_create(2): http://man7.org/linux/man-pages/man2/timer_create.2.html

Ah, indeed timer_create() seem to only create CPUCLOCK_SCHED timers. So that
issue with timer_gettime becoming asynchonous with clock_gettime can't happen
with PROF and VIRT clocks

I see itimers can use those clocks. But there don't seem to be a
similar issue with
getitimer/setitimer as they don't have matching clock reads.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/