Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757875Ab3EGPqg (ORCPT ); Tue, 7 May 2013 11:46:36 -0400 Received: from mail-ia0-f182.google.com ([209.85.210.182]:39851 "EHLO mail-ia0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754639Ab3EGPqf (ORCPT ); Tue, 7 May 2013 11:46:35 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 7 May 2013 08:46:34 -0700 X-Google-Sender-Auth: G37ZaNtLM0n_VTntIW4YhJKNSAE Message-ID: Subject: Re: [PATCH] pstore/ram: fix error return code in ramoops_probe() From: Kees Cook To: Wei Yongjun Cc: Anton Vorontsov , Colin Cross , Tony Luck , yongjun_wei@trendmicro.com.cn, LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 22 On Tue, May 7, 2013 at 4:39 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Good catch, thanks! Acked-by: Kees Cook -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/