Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755483Ab3EGT7h (ORCPT ); Tue, 7 May 2013 15:59:37 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:41252 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700Ab3EGT7e (ORCPT ); Tue, 7 May 2013 15:59:34 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 7 May 2013 21:59:34 +0200 Message-ID: Subject: Re: [PATCH 1/2] leds: lp55xx: support dynamic channel settings in the device tree structure From: Linus Walleij To: "Kim, Milo" Cc: Bryan Wu , Gabriel Fernandez , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 26 On Tue, May 7, 2013 at 9:14 AM, Kim, Milo wrote: > Currently, the LP55xx DT structure supports max 3 channels. > However, LP5523 has max 9 channels and LP5562 has 4 channels. > To enhance this constraint, the DT structure has been changed. > > (a) Use the child node for various channel settings instead of fixed array > (b) Remove 'num_channel' property. > This value can be retrieved by counting the children node. > (c) 'chan-name' property supported > (d) Documentation updates for LP5521 and LP5523 > > Cc: Linus Walleij > Cc: Gabriel Fernandez > Signed-off-by: Milo(Woogyom) Kim This is looking very good to me. Reviewed-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/