Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752986Ab3EHCd7 (ORCPT ); Tue, 7 May 2013 22:33:59 -0400 Received: from [213.199.154.184] ([213.199.154.184]:56851 "EHLO db8outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752368Ab3EHCd5 (ORCPT ); Tue, 7 May 2013 22:33:57 -0400 X-Forefront-Antispam-Report: CIP:157.56.236.101;KIP:(null);UIP:(null);IPV:NLI;H:BY2PRD0510HT003.namprd05.prod.outlook.com;RD:none;EFVD:NLI X-SpamScore: -2 X-BigFish: PS-2(zz98dI936eIzz1f42h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ah1fc6hzz8275dhz2fh2a8h668h839h93fhd24hd2bhf0ah1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah1d0ch1d2eh1d3fh1155h) From: Matthew Garrett To: Qiaowei Ren CC: "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , Xiaoyan Zhang , Gang Wei Subject: Re: [PATCH 1/4] driver: add TXT driver in kernel Thread-Topic: [PATCH 1/4] driver: add TXT driver in kernel Thread-Index: AQHOSvE9AcunBqr7IUa9oxQD3ESIK5j6kqOA Date: Wed, 8 May 2013 02:32:19 +0000 Message-ID: <1367980339.2425.7.camel@x230> References: <1367938519-840-1-git-send-email-qiaowei.ren@intel.com> <1367938519-840-2-git-send-email-qiaowei.ren@intel.com> In-Reply-To: <1367938519-840-2-git-send-email-qiaowei.ren@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.84.4] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: nebula.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r482Y5gc006565 Content-Length: 1447 Lines: 38 On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: > TXT driver is expected to be a better tool to access below resources: > TXT config space, TXT log and SMX parameter. Please explain what these things are in the commit log, the config help and the comment at the top of the driver - it'll make things easier for people later. > + To compile this driver as a module, choose M here; the module will be > + called txt. That's an awfully generic name. intel_txt would be better. > + * This module is expected to be a better tool to access below resources Expected to be or is? :) > + * Data is currently found below You're adding it to ABI, so it shouldn't just be current - are you planning on moving it at any point? Is this functionality that should be under securityfs instead? > + txt_pdev = platform_device_register_simple(DEV_NAME, -1, NULL, 0); This will register even if there's no TXT support on the platform, right? Is there no mechanism for determining whether a platform has TXT support before registering a device? > +module_init(txt_sysfs_init); > +module_exit(txt_sysfs_exit); And you've got no module aliases, so this will never be autoloaded. How does the OS know that the platform implements TXT? -- Matthew Garrett | mjg59@srcf.ucam.org ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?