Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754740Ab3EHLLQ (ORCPT ); Wed, 8 May 2013 07:11:16 -0400 Received: from mail-ee0-f43.google.com ([74.125.83.43]:53157 "EHLO mail-ee0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863Ab3EHLLP (ORCPT ); Wed, 8 May 2013 07:11:15 -0400 Date: Wed, 8 May 2013 12:11:10 +0100 From: Lee Jones To: Mark Brown Cc: Fabio Baltieri , Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Linus Walleij , Ola Lilja Subject: Re: [PATCH 4/6] ASoC: ux500: Update tx tdm slots configuration Message-ID: <20130508111110.GD3459@gmail.com> References: <1367997261-32048-1-git-send-email-fabio.baltieri@linaro.org> <1367997261-32048-5-git-send-email-fabio.baltieri@linaro.org> <20130508110149.GF7478@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130508110149.GF7478@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1210 Lines: 27 On Wed, 08 May 2013, Mark Brown wrote: > On Wed, May 08, 2013 at 09:14:19AM +0200, Fabio Baltieri wrote: > > Update ab8500-codec and mop500_ab8500 tx slot configuration to reflect > > the actual one used by STE. Also update a wrong comment in the process. > > This seems wrong, the individual chip drivers should just be doing > whatever they're being told by the machine driver. Sounds like there's > two fixes needed here - one is to change the TDM API so that the chip > drivers are just implementing configuration supplied by the machine > driver and the other is to change the configuration being done to > whatever is desired. Do you mean that the original implementation is incorrect, or that this patch is doing the wrong thing? I think this patch is a bugfix rather than a opportunity to refactor the driver. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/