Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755599Ab3EHNWZ (ORCPT ); Wed, 8 May 2013 09:22:25 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:62688 "EHLO mail-bk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755012Ab3EHNWY (ORCPT ); Wed, 8 May 2013 09:22:24 -0400 MIME-Version: 1.0 In-Reply-To: <201305081416.06611.arnd@arndb.de> References: <1366910944-3033663-1-git-send-email-arnd@arndb.de> <20130501225748.GD6517@verge.net.au> <201305081416.06611.arnd@arndb.de> Date: Wed, 8 May 2013 15:22:22 +0200 Message-ID: Subject: Re: [PATCH 03/21] ARM: shmobile: don't call irqchip_init unconditionally From: Bastian Hecht To: Arnd Bergmann Cc: Simon Horman , Rob Herring , Bastian Hecht , Kuninori Morimoto , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 43 Hi, 2013/5/8 Arnd Bergmann : > On Thursday 02 May 2013, Simon Horman wrote: >> > > diff --git a/arch/arm/mach-shmobile/intc-r8a7740.c b/arch/arm/mach-shmobile/intc-r8a7740.c >> > > index 8871f77..5dc57f1 100644 >> > > --- a/arch/arm/mach-shmobile/intc-r8a7740.c >> > > +++ b/arch/arm/mach-shmobile/intc-r8a7740.c >> > > @@ -53,14 +53,23 @@ static void __init r8a7740_init_irq_common(void) >> > > >> > > void __init r8a7740_init_irq_of(void) >> > > { >> > > + if (!IS_ENABLED(CONFIG_OF)) >> > > + return; >> > > + >> > > irqchip_init(); >> > >> > Why not have an empty irqchip_init? I'd guess we'll need this on other >> > platforms and your default mach. >> >> Thanks, I think that could work. >> >> I will see about making it so. > > Ping I have sent out a patch adding an empty irqchip_init() when CONFIG_IRQCHIP is not set with the subject [PATCH] irqchip: Add irqchip_init dummy function > Linux-next is still broken for me. There is also anothe shmobile build bug, > I'll send a separate patch for that, which also needs to go into your tree. Oh thanks Arnd for this fix! Cheers, Bastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/