Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756026Ab3EHOSU (ORCPT ); Wed, 8 May 2013 10:18:20 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:54199 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755548Ab3EHOSR (ORCPT ); Wed, 8 May 2013 10:18:17 -0400 Date: Wed, 8 May 2013 15:17:06 +0100 From: Catalin Marinas To: Peter Maydell Cc: Christopher Covington , "linaro-kernel@lists.linaro.org" , "patches@linaro.org" , Rusty Russell , Alexander Graf , "linux-kernel@vger.kernel.org List" , Amit Shah , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" , Pranavkumar Sawargaonkar Subject: Re: [PATCH 0/2] Early printk support for virtio console devices. Message-ID: <20130508141706.GF2703@arm.com> References: <87sj27xxjr.fsf@rustcorp.com.au> <87ip2wr8tp.fsf@rustcorp.com.au> <87txmfo0rl.fsf@rustcorp.com.au> <5189234D.3040208@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 37 On Tue, May 07, 2013 at 04:58:23PM +0100, Peter Maydell wrote: > On 7 May 2013 16:52, Christopher Covington wrote: > > On 05/07/2013 08:19 AM, Peter Maydell wrote: > >> Well, at the moment EARLY_PRINTK is hardcoded to > >> "use some specific UART or equivalent selected at > >> compile time". So the equivalent presumably would > >> be to hard-compile "use virtio-console", but then > >> how does that code know where the virtio-console > >> is in the address space? > > > > arm64 uses a kernel argument. > > This mixes up "information that the user provides to the > kernel" (ie configuration) with "information that QEMU or > kvmtool should provide to the kernel" (ie hardware > description), and would require QEMU/kvmtool to parse > the user's commandline tool to figure out if they > needed to override it or edit it (or alternatively, > would require the user to know internal details of > QEMU/kvmtool's address map for the guest). I think it > would be nicer to keep them separate. I'm not sure it's worth it, the earlyprintk is meant for debugging the early kernel booting code, not for general use (you have the normal console for this). Someone doing platform port should know the address of the uart and pass the right information on the kernel command line to help debug early booting issues. But if someone comes up with some bindings, I won't reject the patch. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/