Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753667Ab3EHPZm (ORCPT ); Wed, 8 May 2013 11:25:42 -0400 Received: from ip4-83-240-18-99.cust.nbox.cz ([83.240.18.99]:53722 "EHLO anemoi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752662Ab3EHPZl (ORCPT ); Wed, 8 May 2013 11:25:41 -0400 X-Greylist: delayed 90461 seconds by postgrey-1.27 at vger.kernel.org; Wed, 08 May 2013 11:25:41 EDT From: Jiri Slaby To: jirislaby@gmail.com Cc: linux-kernel@vger.kernel.org, Jeff Mahoney , Jiri Slaby , linux-fsdevel@vger.kernel.org, Andrew Morton , Vyacheslav Dubeyko Subject: [PATCH v2 07/14] hfs: avoid crash in hfs_bnode_create Date: Wed, 8 May 2013 17:26:04 +0200 Message-Id: <1368026764-3989-1-git-send-email-jslaby@suse.cz> X-Mailer: git-send-email 1.8.2.2 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1342 Lines: 44 From: Jeff Mahoney Commit 634725a92938b0f282b17cec0b007dca77adebd2 removed the BUG_ON in hfs_bnode_create in hfsplus. This patch removes it from the hfs version and avoids an fsfuzzer crash. [v2] - use pr_crit (per Vyacheslav) Signed-off-by: Jeff Mahoney Acked-by: Jeff Mahoney Signed-off-by: Jiri Slaby Cc: linux-fsdevel@vger.kernel.org Cc: Andrew Morton Cc: Vyacheslav Dubeyko --- fs/hfs/bnode.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/hfs/bnode.c b/fs/hfs/bnode.c index f3b1a15..d3fa6bd 100644 --- a/fs/hfs/bnode.c +++ b/fs/hfs/bnode.c @@ -415,7 +415,11 @@ struct hfs_bnode *hfs_bnode_create(struct hfs_btree *tree, u32 num) spin_lock(&tree->hash_lock); node = hfs_bnode_findhash(tree, num); spin_unlock(&tree->hash_lock); - BUG_ON(node); + if (node) { + pr_crit("new node %u already hashed?\n", num); + WARN_ON(1); + return node; + } node = __hfs_bnode_create(tree, num); if (!node) return ERR_PTR(-ENOMEM); -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/