Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758437Ab3EHQGw (ORCPT ); Wed, 8 May 2013 12:06:52 -0400 Received: from mail-vb0-f43.google.com ([209.85.212.43]:41308 "EHLO mail-vb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758385Ab3EHQGs (ORCPT ); Wed, 8 May 2013 12:06:48 -0400 Message-ID: <518A7814.1070604@lwfinger.net> Date: Wed, 08 May 2013 11:06:44 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: "H. Peter Anvin" CC: linux-wireless , LKML , netdev , Dan Williams , "'George0505'" , Joon Ro , Greg KH Subject: Re: Linux driver for Realtek RTL8723AU devices with USB ID 0bda:1724 such as found in Lenovo IdeaPad Yoga 13 References: <5159B52D.3050601@lwfinger.net> <5189B939.4010905@zytor.com> In-Reply-To: <5189B939.4010905@zytor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 33 On 05/07/2013 09:32 PM, H. Peter Anvin wrote: > > So I can verify that this driver works against 3.8.11 (not against > current -linus because of a build failure), and yes, there is Bluetooth > in this device. In fact, it seems to work better than some in-tree > drivers I have seen in the past. > > However, I'm confused as to the above and what it implies for the > purpose of the staging tree. Wasn't the whole point of the staging tree > to have a working-but-ugly driver upstream and have the work to clean it > up happen in the mainline tree instead of off somewhere. Yes, but even staging has some standards. For example, they frown on inclusion of firmware in a massive data block in a file in the driver - it should be in a separate file the /lib/firmware/ tree. In addition, the mainline drivers/net/wireless/ tree is only available to devices that use mac80211 for the software-based MAC layer. That conversion is a serious effort that may never be done, thus the 8723au driver may never leave staging. What are the details of the build failure on the mainline tree? It builds fine here. One possibility is that your source tree has a leftover copy of include/linux/version.h that contains a stale coded value of the kernel version. I just pushed a Makefile fix that causes the compiler to look in the new location for version.h first. If that doesn't work, please post the error. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/