Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757249Ab3EHQ04 (ORCPT ); Wed, 8 May 2013 12:26:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38383 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757219Ab3EHQ0z (ORCPT ); Wed, 8 May 2013 12:26:55 -0400 Date: Wed, 08 May 2013 18:26:56 +0200 Message-ID: From: Takashi Iwai To: Ming Lei Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH 0/3] firmware: Fix usermodehelper deadlock at shutdown In-Reply-To: References: <1367996197-32748-1-git-send-email-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1342 Lines: 38 At Thu, 9 May 2013 00:07:17 +0800, Ming Lei wrote: > > Hi Takashi, > > Sorry for not CC list. > > On Wed, May 8, 2013 at 2:56 PM, Takashi Iwai wrote: > > Hi, > > > > this is a series of patches for the issue we faced in the firmware > > loader code during debugging the problem with dell_rbu driver with > > 3.9 kernel. > > > > The original problem was that the shutdown gets stuck when DELL BIOS > > update is performed. This turned out to be a problem in the firmware > > loader. Although the reason of dell_rbu driver breakage is still > > Sorry, from these patchset, I can't see why it is a problem in firmware. > > > unclear, we should fix the firmware loader side, at least, not to > > stall during shutdown. > > Firstly you need to describe what/why is the stall? In fact, firmware > loading can't stall forever and it will timeout, but the current 60sec > timeout might be too long. The timeout check is activated only when uevent flag is set, and dell_rbu driver doesn't set it explicitly (because it's not supposed to be handled via udev or whatever). Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/