Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757800Ab3EHSTk (ORCPT ); Wed, 8 May 2013 14:19:40 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:39966 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757646Ab3EHSTj (ORCPT ); Wed, 8 May 2013 14:19:39 -0400 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:1b02:6e3b:e5ff:fe16:c028] In-Reply-To: <1368034349-15091-1-git-send-email-dianders@chromium.org> References: <1368034349-15091-1-git-send-email-dianders@chromium.org> Date: Wed, 8 May 2013 11:19:38 -0700 Message-ID: Subject: Re: [PATCH] ARM: exynos: Select PINCTRL_EXYNOS for exynos5 From: Olof Johansson To: Doug Anderson Cc: Kukjin Kim , Thomas Abraham , Simon Glass , Alim Akhtar , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1156 Lines: 35 Hi, On Wed, May 8, 2013 at 10:32 AM, Doug Anderson wrote: > If you've got MACH_EXYNOS5_DT but not MACH_EXYNOS4_DT you'll be > missing the pincontrol definitions. Add them for exynos5. > > Signed-off-by: Doug Anderson > --- > arch/arm/mach-exynos/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 6e77432..cdcd7fa 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -428,6 +428,8 @@ config MACH_EXYNOS5_DT > depends on ARCH_EXYNOS5 > select ARM_AMBA > select CLKSRC_OF > + select PINCTRL > + select PINCTRL_EXYNOS Nit: Seems like this should be selected by the SoC (ARCH_EXYNOS5) instead of the board. Actually, I'm not sure we need the board Kconfig entry long-term; all boards will be dt-only. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/