Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757997Ab3EHSXa (ORCPT ); Wed, 8 May 2013 14:23:30 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:46798 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757789Ab3EHSX3 (ORCPT ); Wed, 8 May 2013 14:23:29 -0400 Date: Wed, 8 May 2013 19:23:05 +0100 From: Russell King - ARM Linux To: Robin Holt Cc: Andrew Morton , "H. Peter Anvin" , Guan Xuetao , Russ Anderson , Linux Kernel Mailing List , the arch/x86 maintainers , Arm Mailing List Subject: Re: [PATCH -v8 11/11] Move arch/x86 reboot= handling to generic kernel. Message-ID: <20130508182304.GP18614@n2100.arm.linux.org.uk> References: <1367937595-32241-1-git-send-email-holt@sgi.com> <1367937595-32241-12-git-send-email-holt@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1367937595-32241-12-git-send-email-holt@sgi.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 589 Lines: 15 On Tue, May 07, 2013 at 09:39:55AM -0500, Robin Holt wrote: > + case 's': > + reboot_mode = REBOOT_WARM; > + case 'h': > + reboot_mode = REBOOT_COLD; > + case 'g': > + reboot_mode = REBOOT_GPIO; Further to Ingo's comments, also note that the above is broken. Any of s,h,g will result in REBOOT_GPIO being set which is clearly wrong. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/