Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756948Ab3EHURc (ORCPT ); Wed, 8 May 2013 16:17:32 -0400 Received: from mail-oa0-f49.google.com ([209.85.219.49]:39465 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413Ab3EHURa (ORCPT ); Wed, 8 May 2013 16:17:30 -0400 Message-ID: <518AB2D6.1050909@lwfinger.net> Date: Wed, 08 May 2013 15:17:26 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: "H. Peter Anvin" CC: linux-wireless , LKML , netdev , Dan Williams , "'George0505'" , Joon Ro , Greg KH Subject: Re: Linux driver for Realtek RTL8723AU devices with USB ID 0bda:1724 such as found in Lenovo IdeaPad Yoga 13 References: <5159B52D.3050601@lwfinger.net> <5189B939.4010905@zytor.com> <518A7814.1070604@lwfinger.net> <518A7D56.3050502@zytor.com> In-Reply-To: <518A7D56.3050502@zytor.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7514 Lines: 128 On 05/08/2013 11:29 AM, H. Peter Anvin wrote: > On 05/08/2013 09:06 AM, Larry Finger wrote: >> On 05/07/2013 09:32 PM, H. Peter Anvin wrote: >>> >>> So I can verify that this driver works against 3.8.11 (not against >>> current -linus because of a build failure), and yes, there is Bluetooth >>> in this device. In fact, it seems to work better than some in-tree >>> drivers I have seen in the past. >>> >>> However, I'm confused as to the above and what it implies for the >>> purpose of the staging tree. Wasn't the whole point of the staging tree >>> to have a working-but-ugly driver upstream and have the work to clean it >>> up happen in the mainline tree instead of off somewhere. >> >> Yes, but even staging has some standards. For example, they frown on >> inclusion of firmware in a massive data block in a file in the driver - >> it should be in a separate file the /lib/firmware/ tree. In addition, >> the mainline drivers/net/wireless/ tree is only available to devices >> that use mac80211 for the software-based MAC layer. That conversion is a >> serious effort that may never be done, thus the 8723au driver may never >> leave staging. >> >> What are the details of the build failure on the mainline tree? It >> builds fine here. One possibility is that your source tree has a >> leftover copy of include/linux/version.h that contains a stale coded >> value of the kernel version. I just pushed a Makefile fix that causes >> the compiler to look in the new location for version.h first. If that >> doesn't work, please post the error. >> > > Unlikely, since the kernel source tree is clean. > > The error is on os_dep/os_intfs.c: > > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c: In function ?rtw_proc_init_one?: > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:315:3: error: implicit declaration > of function ?create_proc_entry? [-Werror=implicit-function-declaration] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:315:11: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:322:3: error: implicit declaration > of function ?create_proc_read_entry? [-Werror=implicit-function-declaration] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:322:9: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:333:21: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:364:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:370:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:372:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:378:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:381:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:389:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:397:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:405:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:412:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:419:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:426:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:433:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:440:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:447:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:454:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:461:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:468:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:475:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:482:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:489:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:496:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:505:9: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:512:9: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:522:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:539:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:545:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:547:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:553:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:555:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:561:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:563:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:569:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:572:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:576:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:582:7: error: dereferencing pointer > to incomplete type I just pushed a "fix" that will allow the driver to build on kernel 3.10-rc0 (aka 3.9-git). This one removes all the procfs stuff. It will be added back in /sysfs later. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/