Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756022Ab3EHVcH (ORCPT ); Wed, 8 May 2013 17:32:07 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:2976 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751520Ab3EHVcE (ORCPT ); Wed, 8 May 2013 17:32:04 -0400 X-Authority-Analysis: v=2.0 cv=L+efspv8 c=1 sm=0 a=rXTBtCOcEpjy1lPqhTCpEQ==:17 a=mNMOxpOpBa8A:10 a=-mNGWZWXaDgA:10 a=5SG0PmZfjMsA:10 a=IkcTkHD0fZMA:10 a=meVymXHHAAAA:8 a=mDu0LJtoDNUA:10 a=Rea1SEVNW_ZoIBXDLXAA:9 a=QEXdDO2ut3YA:10 a=rXTBtCOcEpjy1lPqhTCpEQ==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 74.67.115.198 Message-ID: <1368048721.7373.70.camel@gandalf.local.home> Subject: Re: [PATCH] kmsg: honor dmesg_restrict sysctl on /dev/kmsg From: Steven Rostedt To: Kees Cook Cc: Andrew Morton , Linus Torvalds , Josh Boyer , Kay Sievers , LKML , Eric Paris , Greg Kroah-Hartman , Randy Dunlap Date: Wed, 08 May 2013 17:32:01 -0400 In-Reply-To: References: <20130430172541.GA23382@www.outflux.net> <20130508142223.c4497dc285600f30cc56d21a@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 554 Lines: 16 On Wed, 2013-05-08 at 14:26 -0700, Kees Cook wrote: > Yeah, that'll be fine. I kind of like having the longer rationale in > the commit message for future reference (i.e. destructive vs > non-destructive, etc), but I'd rather see the code fixed. :) There's no reason not to have both, is there? -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/