Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750944Ab3EIEEX (ORCPT ); Thu, 9 May 2013 00:04:23 -0400 Received: from terminus.zytor.com ([198.137.202.10]:47153 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704Ab3EIEEW (ORCPT ); Thu, 9 May 2013 00:04:22 -0400 Message-ID: <518B2033.80300@zytor.com> Date: Wed, 08 May 2013 21:04:03 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Mike Frysinger CC: x86@kernel.org, Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: make stat/statfs 64-bit for x86_64 kernels References: <1368072057-7832-1-git-send-email-vapier@gentoo.org> In-Reply-To: <1368072057-7832-1-git-send-email-vapier@gentoo.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 636 Lines: 18 On 05/08/2013 09:00 PM, Mike Frysinger wrote: > When including these headers in the x32 ABI, the structs get declared > with 32bit sizes which is incorrect. Use long long and such to make > it work both with x32 and x86_64. > > Signed-off-by: Mike Frysinger I'm not sure if it is okay to change the types, even within the same size. Perhaps use __u64/__s64? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/