Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751193Ab3EIENG (ORCPT ); Thu, 9 May 2013 00:13:06 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:55067 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748Ab3EIENE convert rfc822-to-8bit (ORCPT ); Thu, 9 May 2013 00:13:04 -0400 From: "Gupta, Pekon" To: Tony Lindgren , "Nori, Sekhar" CC: "linux-mtd@lists.infradead.org" , "Cousson, Benoit" , "linux@arm.linux.org.uk" , "Philip, Avinash" , "linux-omap@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Hebbar, Gururaja" , "Hiremath, Vaibhav" , "zonque@gmail.com" , "jacmet@sunsite.dk" Subject: RE: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm Thread-Topic: [v2, 3/3] ARM: dts: AM33XX: Add NAND flash device tree data to am335x-evm Thread-Index: AQHORK8kYV+CfdNudU6r5StSMMOqvpjtsT8AgA3N7ACAAM1UcA== Date: Thu, 9 May 2013 04:12:10 +0000 Message-ID: <20980858CB6D3A4BAE95CA194937D5E73E9C320D@DBDE04.ent.ti.com> References: <517F5126.5000509@ti.com> <20130508235404.GX32546@atomide.com> In-Reply-To: <20130508235404.GX32546@atomide.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1257 Lines: 31 > > > > > > am33xx_pinmux: pinmux@44e10800 { > > > pinctrl-names = "default"; > > > - pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0>; > > > + pinctrl-0 = <&matrix_keypad_s0 &volume_keys_s0 > > > + &nandflash_pins_s0>; > > > > Why add this to the board level fallback (called pinctrl hogs, I think)? > > This can be part of nand node you added below so that the pinctrl will > > take effect when nand gets probed instead of all the time. > > Yes we should have all the pinctrl entries under the related drivers. > This makes it easy remux pins during runtime if needed, and also > allows unloading pinctrl-single.ko for development. > Yes, accepted. This has been already fixed in v3 of this patch set. If all fine, then please pull this for next merge.. http://lists.infradead.org/pipermail/linux-mtd/2013-May/046712.html http://lists.infradead.org/pipermail/linux-mtd/2013-May/046814.html (already pulled) http://lists.infradead.org/pipermail/linux-mtd/2013-May/046710.html with regards, pekon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/