Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752033Ab3EIIFe (ORCPT ); Thu, 9 May 2013 04:05:34 -0400 Received: from mga09.intel.com ([134.134.136.24]:40501 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879Ab3EIIF3 (ORCPT ); Thu, 9 May 2013 04:05:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,639,1363158000"; d="scan'208";a="310601278" From: "Ren, Qiaowei" To: Matthew Garrett CC: "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "Wei, Gang" Subject: RE: [PATCH 3/4] driver: provide sysfs interfaces to access TXT log Thread-Topic: [PATCH 3/4] driver: provide sysfs interfaces to access TXT log Thread-Index: AQHOSvE9bxnf/3s/7UWUo8Zw/n8iKpj6wJAAgAG87bA= Date: Thu, 9 May 2013 08:05:25 +0000 Message-ID: <9E0BE1322F2F2246BD820DA9FC397ADE9A9BD2@SHSMSX102.ccr.corp.intel.com> References: <1367938519-840-1-git-send-email-qiaowei.ren@intel.com> <1367938519-840-4-git-send-email-qiaowei.ren@intel.com> <1367990202.2425.26.camel@x230> In-Reply-To: <1367990202.2425.26.camel@x230> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r4985iKp013986 Content-Length: 1386 Lines: 29 On 2013-05-08, Matthew Garrett wrote: > On Tue, 2013-05-07 at 22:55 +0800, Qiaowei Ren wrote: > >> +What: /sys/devices/platform/intel_txt/log/log_header >> +Date: May 2013 >> +KernelVersion: 3.9 > > How different are these logs to the TPM measurements exported via > securityfs? These logs come from tboot (Trusted Boot, an open source, pre-kernel/VMM module that uses Intel® Trusted Execution Technology (Intel® TXT) to perform a measured and verified launch of an OS kernel/VMM.), and should be different from those TPM measurements (from BIOS?) exported via security. >> +What: /sys/devices/platform/intel_txt/log/block_index >> +Date: May 2013 >> +KernelVersion: 3.9 >> +Contact: "Qiaowei Ren" >> +Description: The "block_index" property allows you to set the block >> + index for output. > > So I write a value here and then I see different chunks of log? This > doesn't seem like an optimal interface. What do these logs actually > contain? How do I know which block I should be reading? Yes. Since total log size is bigger than one page 4K, the log have to be displayed in 4K-block indexed by block_index. These logs will be very helpful for txt related debugging. Thanks, Qiaowei ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?