Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752375Ab3EIIfY (ORCPT ); Thu, 9 May 2013 04:35:24 -0400 Received: from mail-db8lp0184.outbound.messaging.microsoft.com ([213.199.154.184]:16111 "EHLO db8outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249Ab3EIIfW convert rfc822-to-8bit (ORCPT ); Thu, 9 May 2013 04:35:22 -0400 X-Forefront-Antispam-Report: CIP:137.71.25.55;KIP:(null);UIP:(null);IPV:NLI;H:nwd2mta1.analog.com;RD:nwd2mail10.analog.com;EFVD:NLI X-SpamScore: 0 X-BigFish: VPS0(z5105h2005kz9371I542I1432Izz1f42h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ah1fc6hzz8275bhz2dh2a8h668h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1b0ah1d0ch1d2eh1d3fh1155h) From: "Zhang, Sonic" To: "Zhang, Sonic" , Libo Chen , "wsa@the-dreams.de" CC: "uclinux-dist-devel@blackfin.uclinux.org" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "lizefan@huawei.com" Subject: RE: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init successful Thread-Topic: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init successful Thread-Index: AQHOTI9QZNJIiFu0Q0GUTG2PZMAtGZj8he6ggAAAxCA= Date: Thu, 9 May 2013 08:34:17 +0000 Message-ID: References: <1368088044-20408-1-git-send-email-libo.chen@huawei.com> <1368088044-20408-2-git-send-email-libo.chen@huawei.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.64.72.242] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: analog.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1913 Lines: 61 Please ignore my Ack. Sonic >-----Original Message----- >From: Zhang, Sonic >Sent: Thursday, May 09, 2013 4:31 PM >To: 'Libo Chen'; wsa@the-dreams.de >Cc: uclinux-dist-devel@blackfin.uclinux.org; linux-kernel@vger.kernel.org; linux- >i2c@vger.kernel.org; lizefan@huawei.com >Subject: RE: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before it init >successful > >Acked-by: Sonic Zhang > >>-----Original Message----- >>From: Libo Chen [mailto:libo.chen@huawei.com] >>Sent: Thursday, May 09, 2013 4:27 PM >>To: Zhang, Sonic; wsa@the-dreams.de >>Cc: uclinux-dist-devel@blackfin.uclinux.org; >>linux-kernel@vger.kernel.org; linux- i2c@vger.kernel.org; >>lizefan@huawei.com; Libo Chen >>Subject: [PATCH v2 1/2] i2c: i2c-bfin-twi: don`t free peripheral before >>it init successful >> >>down out_error_no_irq. When platform_get_irq fail, no need to free >>peripheral >> >>Signed-off-by: Libo Chen >>--- >> drivers/i2c/busses/i2c-bfin-twi.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >>diff --git a/drivers/i2c/busses/i2c-bfin-twi.c >>b/drivers/i2c/busses/i2c-bfin-twi.c >>index 05080c4..6617645 100644 >>--- a/drivers/i2c/busses/i2c-bfin-twi.c >>+++ b/drivers/i2c/busses/i2c-bfin-twi.c >>@@ -709,9 +709,9 @@ static int i2c_bfin_twi_probe(struct >>platform_device *pdev) >> out_error_add_adapter: >> free_irq(iface->irq, iface); >> out_error_req_irq: >>-out_error_no_irq: >> peripheral_free_list((unsigned short *)pdev->dev.platform_data); >> out_error_pin_mux: >>+out_error_no_irq: >> iounmap(iface->regs_base); >> out_error_ioremap: >> out_error_get_res: >>-- >>1.7.1 >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/