Message-ID: <518BAB0B.60401@gmail.com>
Date: Thu, 09 May 2013 07:56:27 -0600
From: David Ahern <dsahern@gmail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130328 Thunderbird/17.0.5
MIME-Version: 1.0
To: Namhyung Kim <namhyung@kernel.org>
CC: linux-kernel@vger.kernel.org, acme@ghostprotocols.net, mingo@kernel.org,
        fweisbec@gmail.com, peterz@infradead.org, jolsa@redhat.com,
        xiaoguangrong@linux.vnet.ibm.com
Subject: Re: [PATCH 10/13] perf kvm: add live mode
References: <1368073909-8825-1-git-send-email-dsahern@gmail.com> <1368073909-8825-11-git-send-email-dsahern@gmail.com> <87obck7d8e.fsf@sejong.aot.lge.com>
In-Reply-To: <87obck7d8e.fsf@sejong.aot.lge.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1293
Lines: 41

On 5/9/13 2:45 AM, Namhyung Kim wrote:
> On Wed,  8 May 2013 22:31:46 -0600, David Ahern wrote:
> [SNIP]
>> +static int perf_kvm__timerfd_create(struct perf_kvm_stat *kvm)
>> +{
>> +	struct itimerspec new_value;
>> +	struct timespec now;
>> +	int rc = -1;
>> +
>> +	kvm->timerfd = timerfd_create(CLOCK_MONOTONIC, TFD_NONBLOCK);
>> +	if (kvm->timerfd < 0) {
>> +		pr_err("timerfd_create failed\n");
>> +		goto out;
>> +	}
>> +
>> +	if (clock_gettime(CLOCK_MONOTONIC, &now) != 0) {
>> +		pr_err("clock_gettime failed: %d\n", errno);
>> +		close(kvm->timerfd);
>> +		goto out;
>> +	}
>> +
>> +	new_value.it_value.tv_sec = now.tv_sec + kvm->display_time;
>> +	new_value.it_value.tv_nsec = now.tv_nsec;
>> +	new_value.it_interval.tv_sec = kvm->display_time;
>> +	new_value.it_interval.tv_nsec = 0;
>> +
>> +	if (timerfd_settime(kvm->timerfd, TFD_TIMER_ABSTIME,
>> +			    &new_value, NULL) != 0) {
>
> Looks like no need to use ABSTIME.

hmmm.... I did that for a reason. I forget why now. Let me poke around 
with it and see if I can remember.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/