Date: Sat, 28 Sep 2002 09:42:20 -0700
From: David Mosberger <davidm@napali.hpl.hp.com>
Message-Id: <200209281642.g8SGgKMA007827@napali.hpl.hp.com>
To: mingo@redhat.com
cc: linux-kernel@vger.kernel.org
Subject: show_stack()/show_trace() prototypes
Reply-to: davidm@hpl.hp.com
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 917
Lines: 23

Ingo, the ksymoops patch adds these to linux/sched.h:

extern void show_trace(unsigned long *stack);
extern void show_stack(unsigned long *stack);

This is not good.  In general, it is not possible to do a reliable
backtrace with just a stack pointer as a starting point (it is
necessary to have access to the entire "preserved" machine state
instead).  I'd suggest to either change the argument to a task_struct
pointer (and update half a dozen platforms or so accordingly), or to
leave the declarations platform-specific like they were before.

Thanks,

	--david

PS: force_sig_info() still drops the siginfo pointer passed to it.
    Will you fix this soon as promised?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/