Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754262Ab3EIQnQ (ORCPT ); Thu, 9 May 2013 12:43:16 -0400 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:17238 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753329Ab3EIQnP (ORCPT ); Thu, 9 May 2013 12:43:15 -0400 X-Greylist: delayed 471 seconds by postgrey-1.27 at vger.kernel.org; Thu, 09 May 2013 12:43:14 EDT From: Robert Jarzmik To: Chao Xie Cc: , , , , , , , , Subject: Re: [PATCH 1/2] Revert "drivers/rtc/rtc-pxa.c: fix set time sync time issue" References: <1367889447-15619-1-git-send-email-chao.xie@marvell.com> <1367889447-15619-2-git-send-email-chao.xie@marvell.com> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 09 May 2013 18:35:12 +0200 In-Reply-To: <1367889447-15619-2-git-send-email-chao.xie@marvell.com> (Chao Xie's message of "Mon, 6 May 2013 21:17:26 -0400") Message-ID: <877gj8i01r.fsf@free.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 44 Chao Xie writes: > This patch have something wrong. > 1.The pxa_sync_time API is not needed. The RTC sync can be done > by user space applications, so in kernel this API is not needed. > 2.The pxa_rtc_open can not be deleted. This change has been > declined during review at the mail list > 3.Based on specification and talked with owner of driver, it > does not matter to set WOM and DOW. > > Only need to keep PSBR control for pxa95x > > This reverts commit 57489fabb7f3fc02483df2125fdbfb8b1bb1fcd8. This commit doesn't exist in Linus's tree. Maybe in linux-next ? Anyway, as you are reverting, please consider this : the commit that exists is : c4243de70f7d536d95196b8a31539298bb15238c "drivers/rtc/rtc-pxa.c: drivers/rtc/rtc-pxa.c: fix alarm not match issue". This commit should be reverted : - because it's wrong : > tm->tm_wday = ((rycr & RDxR_DOW_MASK) >> RDxR_DOW_S) - 1; See how RYCR is used with a RDCR mask ... - because as maintainer I have already nacked this kind of patch : https://patchwork.kernel.org/patch/1819851/ The reasons given here are still valid AFAIK. I'm pretty sure I didn't receive this patch in my mailbox. After I refused ChaoXie first patch, the second "same approach" patch from Liangs was sent in my back. I don't understand how that could happen ... Liangs, please make sure to add me to the reviewers next time ? Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/