Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753095Ab3EIT1h (ORCPT ); Thu, 9 May 2013 15:27:37 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:39813 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752963Ab3EIT1g (ORCPT ); Thu, 9 May 2013 15:27:36 -0400 Date: Thu, 9 May 2013 15:27:35 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Libo Chen cc: grant.likely@linaro.org, , , , , Subject: Re: [PATCH RESEND 3/4] usb: ohci: fix goto wrong tag in err case In-Reply-To: <1368079537-15328-4-git-send-email-libo.chen@huawei.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 34 On Thu, 9 May 2013, Libo Chen wrote: > fix goto wrong tag in usb_hcd_nxp_probe > > Signed-off-by: Libo Chen > --- > drivers/usb/host/ohci-nxp.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/host/ohci-nxp.c b/drivers/usb/host/ohci-nxp.c > index f4988fb..eb294a9 100644 > --- a/drivers/usb/host/ohci-nxp.c > +++ b/drivers/usb/host/ohci-nxp.c > @@ -234,7 +234,7 @@ static int usb_hcd_nxp_probe(struct platform_device *pdev) > if (usb_disabled()) { > dev_err(&pdev->dev, "USB is disabled\n"); > ret = -ENODEV; > - goto out; > + goto out1; > } Instead of renumbering all these statement labels, it would be better to replace them with names that have a real meaning. That would simplify future fixes. Can you submit a patch to do that instead? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/