Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752882Ab3EIT3k (ORCPT ); Thu, 9 May 2013 15:29:40 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:39834 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752237Ab3EIT3j (ORCPT ); Thu, 9 May 2013 15:29:39 -0400 Date: Thu, 9 May 2013 15:29:38 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Libo Chen cc: grant.likely@linaro.org, , , , , Subject: Re: [PATCH RESEND 4/4] usb: tilegx: fix memleak when create hcd fail In-Reply-To: <1368079537-15328-5-git-send-email-libo.chen@huawei.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 42 On Thu, 9 May 2013, Libo Chen wrote: > When usb_create_hcd fail, we should call gxio_usb_host_destroy > > Signed-off-by: Libo Chen > --- > drivers/usb/host/ohci-tilegx.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ohci-tilegx.c b/drivers/usb/host/ohci-tilegx.c > index 1ae7b28..5888fc4 100644 > --- a/drivers/usb/host/ohci-tilegx.c > +++ b/drivers/usb/host/ohci-tilegx.c > @@ -112,8 +112,10 @@ static int ohci_hcd_tilegx_drv_probe(struct platform_device *pdev) > > hcd = usb_create_hcd(&ohci_tilegx_hc_driver, &pdev->dev, > dev_name(&pdev->dev)); > - if (!hcd) > - return -ENOMEM; > + if (!hcd){ > + ret = -ENOMEM; > + goto err_hcd; > + } > > /* > * We don't use rsrc_start to map in our registers, but seems like > @@ -165,6 +167,7 @@ err_have_irq: > err_no_irq: > tilegx_stop_ohc(); > usb_put_hcd(hcd); > +err_hcd: > gxio_usb_host_destroy(&pdata->usb_ctx); > return ret; > } Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/