Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281Ab3EITnv (ORCPT ); Thu, 9 May 2013 15:43:51 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:59154 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419Ab3EITnu (ORCPT ); Thu, 9 May 2013 15:43:50 -0400 MIME-Version: 1.0 In-Reply-To: <1361319761-23873-5-git-send-email-koverstreet@google.com> References: <1361319761-23873-1-git-send-email-koverstreet@google.com> <1361319761-23873-5-git-send-email-koverstreet@google.com> From: Bjorn Helgaas Date: Thu, 9 May 2013 12:43:29 -0700 Message-ID: Subject: Re: [PATCH 04/27] block: Convert integrity to bvec_alloc_bs() To: Kent Overstreet Cc: "linux-kernel@vger.kernel.org" , axboe@kernel.dk, "Martin K. Petersen" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 940 Lines: 26 On Tue, Feb 19, 2013 at 4:22 PM, Kent Overstreet wrote: > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c > index 94fa1c5..8c4c604 100644 > --- a/fs/bio-integrity.c > +++ b/fs/bio-integrity.c > ... > @@ -766,13 +733,14 @@ void bioset_integrity_free(struct bio_set *bs) > { > if (bs->bio_integrity_pool) > mempool_destroy(bs->bio_integrity_pool); > + > + if (bs->bvec_integrity_pool) > + mempool_destroy(bs->bio_integrity_pool); I think this is a copy-and-paste error that results in using bs->bio_integrity_pool after it has been freed. Found by Coverity (CID 1020654). > } > EXPORT_SYMBOL(bioset_integrity_free); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/