Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895Ab3EJHGV (ORCPT ); Fri, 10 May 2013 03:06:21 -0400 Received: from mail-ea0-f180.google.com ([209.85.215.180]:45110 "EHLO mail-ea0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753Ab3EJHGU (ORCPT ); Fri, 10 May 2013 03:06:20 -0400 Date: Fri, 10 May 2013 09:06:16 +0200 From: Ingo Molnar To: Robin Holt Cc: Andrew Morton , "H. Peter Anvin" , Russ Anderson , Russell King , Guan Xuetao , Linux Kernel Mailing List , the arch/x86 maintainers , Arm Mailing List Subject: Re: [PATCH -v8 00/11] Shutdown from reboot_cpuid without stopping other cpus. Message-ID: <20130510070616.GA5763@gmail.com> References: <1368127405-112717-1-git-send-email-holt@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368127405-112717-1-git-send-email-holt@sgi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2875 Lines: 91 * Robin Holt wrote: > We recently noticed that reboot of a 1024 cpu machine takes approx 16 > minutes of just stopping the cpus. The slowdown was tracked to commit > f96972f. > > The current implementation does all the work of hot removing the cpus > before halting the system. We are switching to just migrating to the > reboot_cpu and then continuing with shutdown/reboot. > > The patch set is broken into eleven parts. The first two are planned for > the stable release. The others move the halt/shutdown/reboot related > functions to their own kernel/reboot.c file and then move the handling > of the kernel reboot= kernel parameter to generic kernel code. > > > Changes since -v8 > - Changes reboot_cpu on stack to cpu to fix bug noticed by Russell King. > > - Switched unicore32 and arm from using REBOOT_WARM/COLD to HARD/SOFT. > > - Fixed case statement bug. > > - Went to using simple_strtoul for parsing reboot_cpu=smp###. > > - Made parsing of reboot= not use any #ifdef'd code. > > Changes since -v7. > - Fixed authorship for first patch. > > - Rebased to Linus' current tree (51a26ae7a). > > Changes since -v6. > - Cross compiled all arm architectures (using v3.9 kernel. Fails with > current). > > - Added a #define for non-hotplug case. > > - Add #define for PF_THREAD_BOUND as compatibility to make stable easier. > > - Fixup s/reboot_cpu_id/reboot_cpu/ > > - Add include of linux/uaccess.h to allow building on arm. > > - Removed last remaining checkpatch.pl line length warning on > kernel/reboot.c. > > - Fixed the duplicate handling or the reboot= kernel parameter. > > Changes since -v5. > - Moved the arch/x86 reboot= up to the generic kernel code. > > Changes since -v4. > - Integrated Srivatsa S. Bhat creating cpu_hotplug_disable() > function > > - Integrated comments by Srivatsa S. Bhat. > > - Made one more comment consistent with others in function. > > Changes since -v3. > - Added a tested-by for the original reporter. > > - Fix compile failure found by Joe Perches. > > - Integrated comments by Joe Perches. > > > To: Andrew Morton > Cc: H. Peter Anvin > Cc: Russ Anderson > Cc: Robin Holt > Cc: Russell King > Cc: Guan Xuetao > Cc: Linux Kernel Mailing List > Cc: the arch/x86 maintainers > Cc: Arm Mailing List Looks nice now to me. For the x86 bits: Acked-by: Ingo Molnar Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/