Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752864Ab3EJJGu (ORCPT ); Fri, 10 May 2013 05:06:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50806 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621Ab3EJJGr (ORCPT ); Fri, 10 May 2013 05:06:47 -0400 From: Cong Wang To: linux-kernel@vger.kernel.org Cc: Andrew Morton , Jens Axboe , Cong Wang Subject: [Patch] block: do not leak info to user-space Date: Fri, 10 May 2013 17:06:28 +0800 Message-Id: <1368176789-1973-1-git-send-email-amwang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 882 Lines: 26 From: Cong Wang There is a hole in struct hd_geometry, so we have to zero the struct on stack before copying it to user-space. Cc: Jens Axboe Signed-off-by: Cong Wang --- diff --git a/block/compat_ioctl.c b/block/compat_ioctl.c index 7c668c8..7e5d474 100644 --- a/block/compat_ioctl.c +++ b/block/compat_ioctl.c @@ -59,6 +59,7 @@ static int compat_hdio_getgeo(struct gendisk *disk, struct block_device *bdev, if (!disk->fops->getgeo) return -ENOTTY; + memset(&geo, 0, sizeof(geo)); /* * We need to set the startsect first, the driver may * want to override it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/