Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545Ab3EJJYq (ORCPT ); Fri, 10 May 2013 05:24:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25945 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032Ab3EJJYp (ORCPT ); Fri, 10 May 2013 05:24:45 -0400 From: Cong Wang To: linux-kernel@vger.kernel.org Cc: Andrew Morton , Jan Kara , Cong Wang Subject: [Patch] quota: do not leak info to user-space Date: Fri, 10 May 2013 17:24:33 +0800 Message-Id: <1368177873-4819-1-git-send-email-amwang@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 26 From: Cong Wang There is a hole in struct fs_quota_stat, so we have to zero the struct on stack before copying it to user-space. Cc: Jan Kara Signed-off-by: Cong Wang --- diff --git a/fs/quota/quota.c b/fs/quota/quota.c index c7314f1..2b0c182 100644 --- a/fs/quota/quota.c +++ b/fs/quota/quota.c @@ -211,6 +211,7 @@ static int quota_getxstate(struct super_block *sb, void __user *addr) if (!sb->s_qcop->get_xstate) return -ENOSYS; + memset(&fqs, 0, sizeof(fqs)); ret = sb->s_qcop->get_xstate(sb, &fqs); if (!ret && copy_to_user(addr, &fqs, sizeof(fqs))) return -EFAULT; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/