Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751503Ab3EJKCK (ORCPT ); Fri, 10 May 2013 06:02:10 -0400 Received: from mail.mev.co.uk ([62.49.15.74]:54779 "EHLO mail.mev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751069Ab3EJKCJ (ORCPT ); Fri, 10 May 2013 06:02:09 -0400 Message-ID: <518CC59B.3080208@mev.co.uk> Date: Fri, 10 May 2013 11:02:03 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130410 Thunderbird/17.0.5 MIME-Version: 1.0 To: H Hartley Sweeten CC: Geert Uytterhoeven , "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" , Greg Kroah-Hartman , Ian Abbott Subject: Re: [PATCH 12/12] staging: COMEDI should depend on HAS_DMA References: <1368133494-22198-1-git-send-email-geert@linux-m68k.org> <1368133494-22198-12-git-send-email-geert@linux-m68k.org> In-Reply-To: Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1604 Lines: 45 On 2013-05-09 22:33, H Hartley Sweeten wrote: > On Thursday, May 09, 2013 2:05 PM, Geert Uytterhoeven wrote: >> If NO_DMA=y: >> >> ERROR: "dma_free_coherent" [drivers/staging/comedi/comedi.ko] undefined! >> ERROR: "dma_alloc_coherent" [drivers/staging/comedi/comedi.ko] undefined! >> >> Signed-off-by: Geert Uytterhoeven >> Cc: Ian Abbott >> Cc: Greg Kroah-Hartman >> Cc: devel@driverdev.osuosl.org > > Grr.. > > The error appears to be caused by the dma alloc/free in comedi_buf.c. > These only happen if the (s->async_dma_dir != DMA_NONE). The comedi > core defaults the async_dma_dir to DMA_NONE. The only comedi drivers > that set it are ni_660x, ni_mio_common, and ni_pcidio. > > The mite driver also has a dma_alloc/free. > > Ian, can you think of a better solution than just making comedi depend on HAS_DMA? The only alternative I can think of is to change comedi_buf.c to only compile in the functions if CONFIG_HAS_DMA is defined and to make the following config options depend on HAS_DMA: COMEDI_NI_6527 COMEDI_NI_65XX COMEDI_NI_660X COMEDI_NI_670X COMEDI_NI_LABPC_PCI COMEDI_NI_PCIDIO COMEDI_NI_PCIMIO COMEDI_MITE COMEDI_NI_TIOCMD -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/