Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752650Ab3EJKbR (ORCPT ); Fri, 10 May 2013 06:31:17 -0400 Received: from mail-ea0-f169.google.com ([209.85.215.169]:37987 "EHLO mail-ea0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750Ab3EJKbQ (ORCPT ); Fri, 10 May 2013 06:31:16 -0400 Date: Fri, 10 May 2013 12:31:12 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Jiri Olsa , linux-kernel@vger.kernel.org, Corey Ashford , Frederic Weisbecker , Ingo Molnar , Namhyung Kim , Paul Mackerras , Arnaldo Carvalho de Melo , Andi Kleen , David Ahern , Stephane Eranian Subject: Re: [PATCH 0/9] perf: Adding better precise_ip field handling Message-ID: <20130510103112.GA18755@gmail.com> References: <1368106344-23383-1-git-send-email-jolsa@redhat.com> <20130509150744.GB3039@dyad.programming.kicks-ass.net> <20130509152022.GD1628@krava.brq.redhat.com> <20130510092741.GE3039@dyad.programming.kicks-ass.net> <20130510094053.GF1040@krava.brq.redhat.com> <20130510095345.GG3039@dyad.programming.kicks-ass.net> <20130510101823.GA18427@gmail.com> <20130510102245.GA31235@dyad.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130510102245.GA31235@dyad.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1598 Lines: 40 * Peter Zijlstra wrote: > On Fri, May 10, 2013 at 12:18:23PM +0200, Ingo Molnar wrote: > > > > * Peter Zijlstra wrote: > > > > > > so you mean just detect that by opening events with increasing precise > > > > and see how far we could get.. could be I guess, though the 'precise' > > > > sysfs attribute seems more fit to me > > > > > > The other way around, start at ppp end at !p, then use the one that > > > worked. > > > > Really, instead of this silly 'probing until it works' notion, how about > > the radical idea that we pass to the kernel our request, and the kernel > > fulfills our wish to the best of its ability? > > > > This could be done as a new PERF_COUNT_HW_CPU_CYCLES_PRECISE event, to > > which tooling could migrate, without changing existing semantics. > > > > The problem with the complex probing is that it's totally unnecessary > > complexity that results from lack of passing the right information to the > > kernel. Forcing that will only hinder user-space adoption of our precise > > profiling facilities. > > The part I have trouble with is that its a vague request and you'll get > a vague answer. PERF_COUNT_HW_CPU_CYCLES_PRECISE is not a vague request at all: it means 'get me the most precise cycles profiling available on this system'. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/