Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950Ab3EJLCd (ORCPT ); Fri, 10 May 2013 07:02:33 -0400 Received: from smtp-vbr11.xs4all.nl ([194.109.24.31]:3450 "EHLO smtp-vbr11.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772Ab3EJLCc (ORCPT ); Fri, 10 May 2013 07:02:32 -0400 X-Greylist: delayed 383 seconds by postgrey-1.27 at vger.kernel.org; Fri, 10 May 2013 07:02:31 EDT From: Hans Verkuil To: Lad Prabhakar Subject: Re: [PATCH] davinci: vpfe: fix error path in probe Date: Fri, 10 May 2013 12:55:47 +0200 User-Agent: KMail/1.13.7 (Linux/3.9.0-rc1-durdane; KDE/4.8.4; x86_64; ; ) Cc: LMML , DLOS , LKML , Mauro Carvalho Chehab References: <1368161318-16128-1-git-send-email-prabhakar.csengg@gmail.com> In-Reply-To: <1368161318-16128-1-git-send-email-prabhakar.csengg@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201305101255.47709.hverkuil@xs4all.nl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 41 On Fri May 10 2013 06:48:38 Lad Prabhakar wrote: > From: Lad, Prabhakar > > The error path on failure was calling mutex_unlock(), but there was > no actuall call before for mutex_lock(). This patch fixes this issue > by pointing it to proper go label. > > Reported-by: Jose Pablo Carballo > Signed-off-by: Lad, Prabhakar > --- > drivers/media/platform/davinci/vpfe_capture.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c > index 8c50d30..3827fe1 100644 > --- a/drivers/media/platform/davinci/vpfe_capture.c > +++ b/drivers/media/platform/davinci/vpfe_capture.c > @@ -1837,7 +1837,7 @@ static int vpfe_probe(struct platform_device *pdev) > if (NULL == ccdc_cfg) { > v4l2_err(pdev->dev.driver, > "Memory allocation failed for ccdc_cfg\n"); > - goto probe_free_lock; > + goto probe_free_dev_mem; > } > > mutex_lock(&ccdc_lock); > Just FYI: After applying this patch I get a compiler warning that the probe_free_lock label is unused. I've added a patch removing that label. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/